linux-kernel - Re: [PATCH] ACPI: SPCR: Add new 16550-compatible Serial Port Subtype

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0j9eTL476N7FJ+-m0VpbCdtOQZkZBtgvQ__3U1Jvs_cPg@mail.gmail.com>
Date:   Fri, 25 Jun 2021 19:20:23 +0200
From:   "Rafael J. Wysocki" <rafael@...nel.org>
To:     Marcin Wojtas <mw@...ihalf.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        "open list:ACPI COMPONENT ARCHITECTURE (ACPICA)" <devel@...ica.org>,
        Grzegorz Jaszczyk <jaz@...ihalf.com>,
        Grzegorz Bernacki <gjb@...ihalf.com>, upstream@...ihalf.com,
        Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@....com>,
        Jon Nettleton <jon@...id-run.com>,
        Tomasz Nowicki <tn@...ihalf.com>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Len Brown <lenb@...nel.org>,
        Erik Kaneda <erik.kaneda@...el.com>,
        Robert Moore <robert.moore@...el.com>
Subject: Re: [PATCH] ACPI: SPCR: Add new 16550-compatible Serial Port Subtype

On Fri, Jun 25, 2021 at 7:18 PM Marcin Wojtas <mw@...ihalf.com> wrote:
>
> Hi,
>
> pon., 21 cze 2021 o 22:06 Marcin Wojtas <mw@...ihalf.com> napisał(a):
> >
> > Apologies for the patch prefix, of course it's a first version and
> > unrelated to the networking subsystem.
> >
> > Best regards,
> > Marcin
> >
> >
> > pon., 21 cze 2021 o 22:05 Marcin Wojtas <mw@...ihalf.com> napisał(a):
> > >
> > > The Microsoft Debug Port Table 2 (DBG2) specification revision
> > > May 31, 2017 adds support for 16550-compatible Serial Port
> > > Subtype with parameters defined in Generic Address Structure (GAS) [1]
> > >
> > > Add its support in SPCR parsing routine.
> > >
> > > [1] https://docs.microsoft.com/en-us/windows-hardware/drivers/bringup/acpi-debug-port-table
> > >
> > > Signed-off-by: Marcin Wojtas <mw@...ihalf.com>
> > > ---
> > >  include/acpi/actbl1.h | 1 +
> > >  drivers/acpi/spcr.c   | 1 +
> > >  2 files changed, 2 insertions(+)
> > >
> > > diff --git a/include/acpi/actbl1.h b/include/acpi/actbl1.h
> > > index ce59903c2695..f746012eba8d 100644
> > > --- a/include/acpi/actbl1.h
> > > +++ b/include/acpi/actbl1.h
> > > @@ -498,6 +498,7 @@ struct acpi_dbg2_device {
> > >  #define ACPI_DBG2_ARM_SBSA_GENERIC  0x000E
> > >  #define ACPI_DBG2_ARM_DCC           0x000F
> > >  #define ACPI_DBG2_BCM2835           0x0010
> > > +#define ACPI_DBG2_16550_WITH_GAS    0x0012
> > >
> > >  #define ACPI_DBG2_1394_STANDARD     0x0000
> > >
> > > diff --git a/drivers/acpi/spcr.c b/drivers/acpi/spcr.c
> > > index 88460bacd5ae..25c2d0be953e 100644
> > > --- a/drivers/acpi/spcr.c
> > > +++ b/drivers/acpi/spcr.c
> > > @@ -136,6 +136,7 @@ int __init acpi_parse_spcr(bool enable_earlycon, bool enable_console)
> > >                 break;
> > >         case ACPI_DBG2_16550_COMPATIBLE:
> > >         case ACPI_DBG2_16550_SUBSET:
> > > +       case ACPI_DBG2_16550_WITH_GAS:
> > >                 uart = "uart";
> > >                 break;
> > >         default:
> > > --
>
> Do you have any comments / remarks to the patch?

Yes, I do, but I will get back to you next week.

Thanks!