linux-kernel - Re: [PATCH] ELF: add and use SUPRESS_WARN_UNUSED

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1de70b4e-722e-3c42-1c1d-06d6d1334206@infradead.org>
Date:   Fri, 25 Jun 2021 14:11:39 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Alexey Dobriyan <adobriyan@...il.com>,
        Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        Miguel Ojeda <ojeda@...nel.org>
Subject: Re: [PATCH] ELF: add and use SUPRESS_WARN_UNUSED_RESULT

On 6/25/21 2:10 PM, Alexey Dobriyan wrote:
> On Fri, Jun 25, 2021 at 10:34:29PM +0200, Miguel Ojeda wrote:
>> On Fri, Jun 25, 2021 at 9:52 PM Alexey Dobriyan <adobriyan@...il.com> wrote:
>>>
>>> +/*
>>> + * "(void)" is enough for clang but not for gcc.
>>> + */
>>> +#define SUPRESS_WARN_UNUSED_RESULT     (void)!
>>
>> While it is related to the attribute, this macro is not an attribute,
>> so please add it somewhere else.
> 
> This is natural place. If you're supressing WUR, then the WUR macro
> itself is defined implying that the header has been included.
> 
>> By the way, the name has a typo.
> 
> Ha!
> 

as in Aha!?

s/SUPRESS/SUPPRESS/