linux-kernel - Re: [PATCH v3 0/3] kasan: add memory corruption identification support for hw tag-based kasan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9e906af1182a9039886b0f86525106df381a6255.camel@mediatek.com>
Date:   Sat, 26 Jun 2021 18:13:08 +0800
From:   Kuan-Ying Lee <Kuan-Ying.Lee@...iatek.com>
To:     Marco Elver <elver@...gle.com>
CC:     Andrey Ryabinin <ryabinin.a.a@...il.com>,
        Alexander Potapenko <glider@...gle.com>,
        Andrey Konovalov <andreyknvl@...il.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Matthias Brugger" <matthias.bgg@...il.com>,
        kasan-dev <kasan-dev@...glegroups.com>,
        LKML <linux-kernel@...r.kernel.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        Linux ARM <linux-arm-kernel@...ts.infradead.org>,
        <linux-mediatek@...ts.infradead.org>,
        wsd_upstream <wsd_upstream@...iatek.com>,
        <chinwen.chang@...iatek.com>, <nicholas.tang@...iatek.com>,
        <kuan-ying.lee@...iatek.com>
Subject: Re: [PATCH v3 0/3] kasan: add memory corruption identification
 support for hw tag-based kasan

On Mon, 2021-06-21 at 14:45 +0200, Marco Elver wrote:
> On Sun, 20 Jun 2021 at 13:48, Kuan-Ying Lee <
> Kuan-Ying.Lee@...iatek.com> wrote:
> > 
> > Add memory corruption identification for hardware tag-based KASAN
> > mode.
> > 
> > Changes since v3:
> >  - Preserve Copyright from hw_tags.c/sw_tags.c and
> >    report_sw_tags.c/report_hw_tags.c
> >  - Make non-trivial change in kasan sw tag-based mode
> > 
> > Changes since v2:
> >  - Thanks for Marco's Suggestion
> >  - Rename the CONFIG_KASAN_SW_TAGS_IDENTIFY
> >  - Integrate tag-based kasan common part
> >  - Rebase to latest linux-next
> > 
> > Kuan-Ying Lee (3):
> >   kasan: rename CONFIG_KASAN_SW_TAGS_IDENTIFY to
> >     CONFIG_KASAN_TAGS_IDENTIFY
> >   kasan: integrate the common part of two KASAN tag-based modes
> >   kasan: add memory corruption identification support for hardware
> >     tag-based mode
> 
> I think this looks fine, thank you for your efforts. How did you test
> this? Did you run the lib/test_kasan module with both SW_TAGS and
> HW_TAGS mode? I was about to run that before adding my Reviewed-by.

Thanks for the reminder.
Yes, I run the lib/test_kasan module with SW_TAGS and HW_TAGS mode. :)

> 
> Andrey, Alex, if you have time, please have a quick look at the
> series.
> 
> Thanks,
> -- Marco