linux-kernel - Re: [PATCH] mac80211: Reject zero MAC address in sta_info_insert

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <41d9471d-a354-2a83-816a-46190fcc10da@huawei.com>
Date:   Sat, 26 Jun 2021 18:48:13 +0800
From:   YueHaibing <yuehaibing@...wei.com>
To:     <johannes@...solutions.net>, <davem@...emloft.net>,
        <kuba@...nel.org>, <periyasa@...eaurora.org>
CC:     <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mac80211: Reject zero MAC address in
 sta_info_insert_check()

Pls drop this.

On 2021/6/26 18:38, YueHaibing wrote:
> As commit 52dba8d7d5ab ("mac80211: reject zero MAC address in add station")
> said, we don't consider all-zeroes to be a valid MAC address in most places,
> so also reject it here.
> 
> Reported-by: syzbot+ef4ca92d9d6f5ba2f880@...kaller.appspotmail.com
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>  net/mac80211/sta_info.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
> index f2fb69da9b6e..3a6887fc9160 100644
> --- a/net/mac80211/sta_info.c
> +++ b/net/mac80211/sta_info.c
> @@ -547,7 +547,7 @@ static int sta_info_insert_check(struct sta_info *sta)
>  		return -ENETDOWN;
>  
>  	if (WARN_ON(ether_addr_equal(sta->sta.addr, sdata->vif.addr) ||
> -		    is_multicast_ether_addr(sta->sta.addr)))
> +		    is_valid_ether_addr(sta->sta.addr)))
>  		return -EINVAL;
>  
>  	/* The RCU read lock is required by rhashtable due to
>