linux-kernel - regulator: rtmv20: Wrong mask for strobe-polarity-high/vsync-polarity-high?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:   Sat, 26 Jun 2021 21:50:47 +0800
From:   Axel Lin <axel.lin@...ics.com>
To:     ChiYuan Huang <cy_huang@...htek.com>
Cc:     Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: regulator: rtmv20: Wrong mask for strobe-polarity-high/vsync-polarity-high?

Hi ChiYuan,

In drivers/regulator/rtmv20-regulator.c

#define RTMV20_STROBEPOL_MASK   BIT(1)
#define RTMV20_VSYNPOL_MASK     BIT(1)

                { "richtek,strobe-polarity-high", 1, 0, 1, 1,
RTMV20_REG_LDCTRL2,
                        RTMV20_STROBEPOL_MASK },
                { "richtek,vsync-polarity-high", 1, 0, 1, 1, RTMV20_REG_LDCTRL2,
                        RTMV20_VSYNPOL_MASK },

Both "richtek,strobe-polarity-high" and "richtek,vsync-polarity-high"
read the same register with the same mask.
Looks like one of the register or mask definitions is wrong.
I think this needs to be double checked.

Regards,
Axel