linux-kernel - Re: [PATCH] mmc: Prefer unsigned int to bare use of unsigned

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <YNeb4rJizAyr4y5y@qmqm.qmqm.pl>
Date:   Sat, 26 Jun 2021 23:28:02 +0200
From:   Michał Mirosław <mirq-linux@...e.qmqm.pl>
To:     Jinchao Wang <wjc@...rlc.com>
Cc:     ulf.hansson@...aro.org, udovic.desroches@...rochip.com,
        nicolas.ferre@...rochip.com, s.hauer@...gutronix.de,
        shawnguo@...nel.org, linux-kernel@...r.kernel.org,
        inux-mmc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-omap@...r.kernel.org, linux-tegra@...r.kernel.org
Subject: Re: [PATCH] mmc: Prefer unsigned int to bare use of unsigned

On Sat, Jun 26, 2021 at 04:36:57PM +0800, Jinchao Wang wrote:
> Fix checkpatch warnings:
>     WARNING: Prefer 'unsigned int' to bare use of 'unsigned'
[...]
>  int mmc_send_adtc_data(struct mmc_card *card, struct mmc_host *host, u32 opcode,
> -		       u32 args, void *buf, unsigned len)
> +		       u32 args, void *buf, unsigned int len)

I'd suggest size_t for the 'size' and 'len' arguments while at it.

> --- a/drivers/mmc/host/cb710-mmc.c
[...]

For cb710 part:

Acked-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>

BTW, I think you should directly Cc: driver maintainers with each driver
having its separate patch. I noticed code for cb710 in this patch purely
by chance.

Best Regards
Michał Mirosław