linux-kernel - Re: [PATCH v2] serial: amba-pl011: add RS485 support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a89dec92-e764-c833-bbeb-ba3d84381e78@kernel.org>
Date:   Sat, 26 Jun 2021 05:41:45 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     Lino Sanfilippo <LinoSanfilippo@....de>
Cc:     Greg KH <gregkh@...uxfoundation.org>, linux@...linux.org.uk,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] serial: amba-pl011: add RS485 support

Hi,

On 25. 06. 21, 13:21, Lino Sanfilippo wrote:
> Thats right, the logic has slightly changed. I thought this does not matter as long as
> we make sure that exactly one of both ON_SEND or AFTER_SEND is set.

I actually don't know. But I would remain consistent with other drivers.

> We can stick with the logic
> in serial8250_em485_config() (i.e. always set ON_SEND and delete AFTER_SEND in case
> of an invalid setting), but I think this will require more than the four lines that we
> have now (especially if we want to avoid the !!).

What if you used only a single !?

thanks,
-- 
js
suse labs