linux-kernel - Re: [PATCH] regulator: hi6421v600: Fix setting wrong driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFRkauBKCpp95yFEYsH6TEfzSWc--zqR8oLVkmdExmTOiVS-iw@mail.gmail.com>
Date:   Sat, 26 Jun 2021 08:48:56 +0800
From:   Axel Lin <axel.lin@...ics.com>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc:     Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: hi6421v600: Fix setting wrong driver_data

> > -     mutex_init(&sreg->enable_mutex);
> > +     mutex_init(&priv->enable_mutex);
>
>
> > +     platform_set_drvdata(pdev, priv);
>
> This won't work, as platform data was already set, as it is already used
> as part of the MFD/SPMI binding logic. With the current

I think you mixed dev->platform_data with dev->driver_data.
Can you check again?

Regards,
Axel