linux-kernel - Re: [PATCH v2] gpio: mt7621: support gpio-line-names property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfM-35tQMRh98mtg2XmDOJFnmjdYRKZZoi9ADm=AT2xUw@mail.gmail.com>
Date:   Sun, 27 Jun 2021 12:33:18 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Sergio Paracuellos <sergio.paracuellos@...il.com>
Cc:     "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        git@...nthomson.fastmail.com.au,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        neil@...wn.name, opensource@...rst.com,
        Nicholas Mc Guire <hofrat@...dl.org>
Subject: Re: [PATCH v2] gpio: mt7621: support gpio-line-names property

On Sat, Jun 26, 2021 at 7:18 PM Sergio Paracuellos
<sergio.paracuellos@...il.com> wrote:
>
> The default handling of the gpio-line-names property by the
> gpiolib-of implementation does not work with the multiple
> gpiochip banks per device structure used by the gpio-mt7621
> driver.
>
> This commit adds driver level support for the device tree
> property so that GPIO lines can be assigned friendly names.



> Signed-off-by: Sergio Paracuellos <sergio.paracuellos@...il.com>
> ---
> Hi,
>
> This driver has three gpiochips with 32 gpios each. Core implementation

implementation


> got gpio's repeated along each gpio chip if chip.names is not assigned.
> To avoid this behaviour driver will set this names as empty or

the driver
these names

> with desired friendly line names. Consider the following sample with
> minimal entries for the first chip with this patch changes applied:

The same comment as per v1:

Any idea why it's not a duplicate of
https://elixir.bootlin.com/linux/v5.13-rc7/C/ident/devprop_gpiochip_set_names,
and why the latter is not called in your case?


--
With Best Regards,
Andy Shevchenko