linux-kernel - Re: [PATCH] x86/tools/relocs: Mark die() with the printf function attr format

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YNneDYWw4MtQh0WH@kroah.com>
Date:   Mon, 28 Jun 2021 16:34:53 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Borislav Petkov <bp@...en8.de>
Cc:     "H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/tools/relocs: Mark die() with the printf function
 attr format

On Mon, Jun 28, 2021 at 04:25:45PM +0200, Borislav Petkov wrote:
> On Sun, Jun 27, 2021 at 05:01:28PM +0200, Greg Kroah-Hartman wrote:
> > This works for me!  It should fix the static checking tool that keeps
> > tripping over this pointless warning :)
> > 
> > Want to turn it into a real patch?
> 
> How's that?
> 
> ---
> From: Borislav Petkov <bp@...e.de>
> 
> Mark die() as a function which accepts printf-style arguments so that
> the compiler can typecheck them against the supplied format string.
> 
> Use the C99 inttypes.h format specifiers as relocs.c gets built for both
> 32- and 64-bit.
> 
> Original version of the patch by Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> Signed-off-by: Borislav Petkov <bp@...e.de>
> ---
>  arch/x86/tools/relocs.c | 37 ++++++++++++++++++++-----------------
>  arch/x86/tools/relocs.h |  1 +
>  2 files changed, 21 insertions(+), 17 deletions(-)

Reviewed-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>