linux-kernel - Re: [PATCH] drm/amdgpu: use kvcalloc for entry->entries

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ffe07902-c0a3-4bb9-7abb-ae6020dc9d80@amd.com>
Date:   Mon, 28 Jun 2021 17:00:54 +0200
From:   Christian König <christian.koenig@....com>
To:     huqiqiao <huqiqiao@...ontech.com>, alexander.deucher@....com
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amdgpu: use kvcalloc for entry->entries



Am 25.06.21 um 04:03 schrieb huqiqiao:
> malloc_array + __GFP_ZERO is the same with kvcalloc.
>
> Signed-off-by: huqiqiao <huqiqiao@...ontech.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index b8c31e3469c0..5cadfadc625f 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -909,7 +909,7 @@ static int amdgpu_vm_alloc_pts(struct amdgpu_device *adev,
>   
>   		num_entries = amdgpu_vm_num_entries(adev, cursor->level);
>   		entry->entries = kvcalloc(num_entries,
> -					sizeof(*entry->entries), GFP_KERNEL);
> +			sizeof(*entry->entries), GFP_KERNEL);

All you seem to do here is to mess up the indentation?

Christian.

>   		if (!entry->entries)
>   			return -ENOMEM;
>   	}