linux-kernel - Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YNnjh3xxyaZZSo9N@ninjato>
Date:   Mon, 28 Jun 2021 16:58:15 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Jie Deng <jie.deng@...el.com>,
        Linux I2C <linux-i2c@...r.kernel.org>,
        virtualization@...ts.linux-foundation.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        conghui.chen@...el.com, kblaiech@...lanox.com,
        jarkko.nikula@...ux.intel.com,
        Sergey Semin <Sergey.Semin@...kalelectronics.ru>,
        Mike Rapoport <rppt@...nel.org>, loic.poulain@...aro.org,
        Tali Perry <tali.perry1@...il.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        yu1.wang@...el.com, shuo.a.liu@...el.com,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Stefan Hajnoczi <stefanha@...hat.com>,
        Paolo Bonzini <pbonzini@...hat.com>
Subject: Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver


> You can fine Viresh's vhost-user implementation at
> https://lore.kernel.org/qemu-devel/cover.1617278395.git.viresh.kumar@linaro.org/t/#m3b5044bad9769b170f505e63bd081eb27cef8db2

It looks OK so far; yet, it is not complete. But it might be bearable
in the end.

> As you say, it does get a bit clumsy, but I think there is also a good argument
> to be made that the clumsiness is based on the host Linux user interface
> more than the on the requirements of the physical interface,
> and that should not have to be reflected in the virtio specification.

Makes sense to me.

> Right, this one has come up before as well: the preliminary result
> was to assume that this probably won't be needed, but would be easy
> enough to add later if necessary.

If adding support incrementally works for such an interface, this makes
sense as well.

So, where are we? As I understand, this v10 does not support I2C
transactions (or I2C_RDWR as you said). But you want to support all
clients. So, this doesn't match, or?


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)