linux-kernel - Re: [PATCH] staging: rtl8723bs: Fix a resource leak in sd_int

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1ed687fa-3831-8dcf-35a4-6e32f5c26e97@redhat.com>
Date:   Mon, 28 Jun 2021 17:35:26 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Xiangyang Zhang <xyz.sun.ok@...il.com>, gregkh@...uxfoundation.org
Cc:     Larry.Finger@...inger.net, fabioaiuto83@...il.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: rtl8723bs: Fix a resource leak in sd_int_dpc

Hi,

On 6/28/21 5:22 PM, Xiangyang Zhang wrote:
> The "c2h_evt" variable is not freed when function call
> "c2h_evt_read_88xx" failed
> 
> Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")
> Signed-off-by: Xiangyang Zhang <xyz.sun.ok@...il.com>

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans



> ---
>  drivers/staging/rtl8723bs/hal/sdio_ops.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/rtl8723bs/hal/sdio_ops.c b/drivers/staging/rtl8723bs/hal/sdio_ops.c
> index 2dd251ce177e..a545832a468e 100644
> --- a/drivers/staging/rtl8723bs/hal/sdio_ops.c
> +++ b/drivers/staging/rtl8723bs/hal/sdio_ops.c
> @@ -909,6 +909,8 @@ void sd_int_dpc(struct adapter *adapter)
>  				} else {
>  					rtw_c2h_wk_cmd(adapter, (u8 *)c2h_evt);
>  				}
> +			} else {
> +				kfree(c2h_evt);
>  			}
>  		} else {
>  			/* Error handling for malloc fail */
>