[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1624896105-26852-1-git-send-email-mansur@codeaurora.org>
Date: Mon, 28 Jun 2021 21:31:45 +0530
From: Mansur Alisha Shaik <mansur@...eaurora.org>
To: bryan.odonoghue@...aro.org, linux-media@...r.kernel.org,
stanimir.varbanov@...aro.org
Cc: linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
vgarodia@...eaurora.org, dikshita@...eaurora.org,
Mansur Alisha Shaik <mansur@...eaurora.org>
Subject: [V2] venus: helper: do not set constrained parameters for UBWC
onstrained parameters are to override the default alignment for
a given color format. By default venus hardware has alignments as
128x32, but NV12 was defined differently to meet various usecases.
Compressed NV12 has always been aligned as 128x32, hence not needed
to override the default alignment.
Fixes: bc28936bbba9 ("media: venus: helpers, hfi, vdec: Set actual plane
constraints to FW")
Signed-off-by: Mansur Alisha Shaik <mansur@...eaurora.org>
Changes in V2:
- Elaborated commit message as per comments by Bryan
---
drivers/media/platform/qcom/venus/helpers.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/media/platform/qcom/venus/helpers.c b/drivers/media/platform/qcom/venus/helpers.c
index 1fe6d46..601ee3e 100644
--- a/drivers/media/platform/qcom/venus/helpers.c
+++ b/drivers/media/platform/qcom/venus/helpers.c
@@ -1137,8 +1137,12 @@ int venus_helper_set_format_constraints(struct venus_inst *inst)
if (!IS_V6(inst->core))
return 0;
+ if (inst->opb_fmt == HFI_COLOR_FORMAT_NV12_UBWC)
+ return 0;
+
pconstraint.buffer_type = HFI_BUFFER_OUTPUT2;
pconstraint.num_planes = 2;
+
pconstraint.plane_format[0].stride_multiples = 128;
pconstraint.plane_format[0].max_stride = 8192;
pconstraint.plane_format[0].min_plane_buffer_height_multiple = 32;
--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation
Powered by blists - more mailing lists