linux-kernel - Re: [PATCH] spi: <linux/spi/spi.h>: add missing struct kernel-doc entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <32f6bf08-a80f-7d47-18b2-42f6516c2772@infradead.org>
Date:   Mon, 28 Jun 2021 09:56:55 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Lukas Wunner <lukas@...ner.de>
Cc:     linux-kernel@...r.kernel.org,
        "William A . Kennington III" <wak@...gle.com>,
        Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org
Subject: Re: [PATCH] spi: <linux/spi/spi.h>: add missing struct kernel-doc
 entry

On 6/28/21 12:05 AM, Lukas Wunner wrote:
> On Sun, Jun 27, 2021 at 05:40:23PM -0700, Randy Dunlap wrote:
>> --- linux-next-20210625.orig/include/linux/spi/spi.h
>> +++ linux-next-20210625/include/linux/spi/spi.h
>> @@ -339,6 +339,7 @@ extern struct spi_device *spi_new_ancill
>>   * @max_speed_hz: Highest supported transfer speed
>>   * @flags: other constraints relevant to this driver
>>   * @slave: indicates that this is an SPI slave controller
>> + * @devm_allocated: flag indicating this is a non-devres managed controller
> 
> Actually the flag indicates that the *allocation* of the controller *is*
> devres-managed, so instead of the above I'd suggest something along the
> lines of:
> 
>  * @devm_allocated: whether allocation of this struct is devres-managed
> 
> Thanks,

Hi Lukas,

OK, I'll change it like that.
I had just copied a comment from below in that same file.
I think that I should fix that comment as well.

Thanks.