linux-kernel - Re: [PATCH] hfsplus: report create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <E07732F5-A3AA-4E32-80C4-8020E2086987@dubeyko.com>
Date:   Mon, 28 Jun 2021 10:04:39 -0700
From:   Viacheslav Dubeyko <slava@...eyko.com>
To:     Chung-Chiang Cheng <shepjeng@...il.com>
Cc:     christian.brauner@...ntu.com,
        Linux FS Devel <linux-fsdevel@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        jamorris@...ux.microsoft.com, axboe@...nel.dk,
        cccheng@...ology.com, Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] hfsplus: report create_date to kstat.btime



> On Apr 16, 2021, at 10:21 AM, Chung-Chiang Cheng <shepjeng@...il.com> wrote:
> 
> The create_date field of inode in hfsplus is corresponding to kstat.btime
> and could be reported in statx.
> 
> Signed-off-by: Chung-Chiang Cheng <cccheng@...ology.com>
> ---
> fs/hfsplus/inode.c | 5 +++++
> 1 file changed, 5 insertions(+)
> 
> diff --git a/fs/hfsplus/inode.c b/fs/hfsplus/inode.c
> index 078c5c8a5156..aab3388a0fd7 100644
> --- a/fs/hfsplus/inode.c
> +++ b/fs/hfsplus/inode.c
> @@ -278,6 +278,11 @@ int hfsplus_getattr(struct user_namespace *mnt_userns, const struct path *path,
> 	struct inode *inode = d_inode(path->dentry);
> 	struct hfsplus_inode_info *hip = HFSPLUS_I(inode);
> 
> +	if (request_mask & STATX_BTIME) {
> +		stat->result_mask |= STATX_BTIME;
> +		stat->btime = hfsp_mt2ut(hip->create_date);
> +	}
> +
> 	if (inode->i_flags & S_APPEND)
> 		stat->attributes |= STATX_ATTR_APPEND;
> 	if (inode->i_flags & S_IMMUTABLE)
> -- 
> 2.25.1
> 

Looks good for me.

Reviewed-by: Viacheslav Dubeyko <slava@...eyko.com>

Thanks,
Slava.