linux-kernel - Re: [PATCH v4 5/5] x86/kvm: Add guest support for detecting and enabling SEV Live Migration feature.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210628193441.GB23232@ashkalra_ubuntu_server>
Date:   Mon, 28 Jun 2021 19:34:41 +0000
From:   Ashish Kalra <ashish.kalra@....com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Steve Rutherford <srutherford@...gle.com>, pbonzini@...hat.com,
        seanjc@...gle.com, tglx@...utronix.de, mingo@...hat.com,
        hpa@...or.com, joro@...tes.org, thomas.lendacky@....com,
        x86@...nel.org, kvm@...r.kernel.org, linux-kernel@...r.kernel.org,
        brijesh.singh@....com
Subject: Re: [PATCH v4 5/5] x86/kvm: Add guest support for detecting and
 enabling SEV Live Migration feature.

Hello Steve,

Do you have any final thoughts on this ?

I do need to resend the patch as per Boris's review below and i want to
do that before the merge window closes. 

Thanks,
Ashish

On Sat, Jun 26, 2021 at 12:22:52AM +0200, Borislav Petkov wrote:
> On Fri, Jun 25, 2021 at 02:02:32PM -0700, Steve Rutherford wrote:
> > Boris, do you have any thoughts on the kexec aspect of this change?
> 
> I'm suspecting you're asking here the wrong guy - I think you mean
> Paolo.
> 
> But if I were to give some thoughts on this, I'd first request that this
> patch be split because it is doing a bunch of things at once.
> 
> Then, I have no clue what "kexec support for SEV Live Migration" is. So
> this whole use case would need a lot more detailed explanation of all
> the moving parts and the "why" and the "because" and so on...
> 
> But I'm no virt guy so perhaps this all makes sense to virt folks.
> 
> Oh, and there's silly stuff like
> 
> +static int __init setup_efi_kvm_sev_migration(void)
> {
> 	...
> 	return true;
> }
> 
> returning a bool but that's minor.
> 
> -- 
> Regards/Gruss,
>     Boris.
> 
> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpeople.kernel.org%2Ftglx%2Fnotes-about-netiquette&amp;data=04%7C01%7CAshish.Kalra%40amd.com%7Cfca523e6b5b64a467b0408d93827ccc1%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637602565894090530%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=JmqtrGxhzgVczPYWdCKEyRIxDDRcDI2Q%2FI83j2dxhGE%3D&amp;reserved=0