linux-kernel - Re: [PATCH v1] mtd: spi-nor: Add support for XM25QH64C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0a9ea6f8-b8d1-cda8-e2c0-652adf957a90@microchip.com>
Date:   Mon, 28 Jun 2021 05:17:11 +0000
From:   <Tudor.Ambarus@...rochip.com>
To:     <code@...o-schneider.ch>, <linux-mtd@...ts.infradead.org>
CC:     <sr@...x.de>, <reto.schneider@...qvarnagroup.com>,
        <miquel.raynal@...tlin.com>, <p.yadav@...com>, <richard@....at>,
        <vigneshr@...com>, <linux-kernel@...r.kernel.org>,
        <michael@...le.cc>
Subject: Re: [PATCH v1] mtd: spi-nor: Add support for XM25QH64C

On 6/17/21 6:06 PM, Reto Schneider wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
> Hi all,
> 
> On 17.06.21 16:19, Michael Walle wrote:
>> That is up to the maintainers, but sooner or later we will have to face
>> the problem regarding the duplicate IDs.
> 
> A strongly worded statement by the maintainer(s) ("the Linux crowd")
> against ignoring the continuation codes might help (me) to put pressure
> on non-compliant manufacturers.
> 

We saw few ID collisions even between flashes of the same manufacturer, macronix.
Reusing flash IDs without providing an extended ID field, or ignoring the
continuation codes is bad design, and I would avoid using such flash. But I won't
reject new flash additions solely because they have a wrong identification mechanism.
We'll cast an indirect public shame on the collisions by writing hackish code when
trying to differentiate between the flashes in software.