linux-kernel - Re: linux-next: build failure after merge of the tip tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YNlhMttVJx/mBUKu@gmail.com>
Date:   Mon, 28 Jun 2021 07:42:10 +0200
From:   Ingo Molnar <mingo@...nel.org>
To:     Stephen Rothwell <sfr@...b.auug.org.au>
Cc:     Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
        "H. Peter Anvin" <hpa@...or.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: linux-next: build failure after merge of the tip tree


* Stephen Rothwell <sfr@...b.auug.org.au> wrote:

> Hi all,
> 
> After merging the tip tree, today's linux-next build (x86_64 allmodconfig)
> failed like this:
> 
> In file included from include/linux/module.h:21,
>                  from include/kunit/test.h:15,
>                  from kernel/time/time_test.c:3:
> kernel/time/time_test.c:99:16: error: expected ',' or ';' before 'GPL'
>    99 | MODULE_LICENSE(GPL);
>       |                ^~~
> include/linux/moduleparam.h:26:47: note: in definition of macro '__MODULE_INFO'
>    26 |   = __MODULE_INFO_PREFIX __stringify(tag) "=" info
>       |                                               ^~~~
> include/linux/module.h:229:46: note: in expansion of macro 'MODULE_INFO'
>   229 | #define MODULE_LICENSE(_license) MODULE_FILE MODULE_INFO(license, _license)
>       |                                              ^~~~~~~~~~~
> kernel/time/time_test.c:99:1: note: in expansion of macro 'MODULE_LICENSE'
>    99 | MODULE_LICENSE(GPL);
>       | ^~~~~~~~~~~~~~
> 
> Caused by commit
> 
>   34c7342ac1b4 ("time/kunit: Add missing MODULE_LICENSE()")

Yeah, that should be "GPL". I amended the commit, so this bug should be 
gone by tomorrow.

Thanks,

	Ingo