linux-kernel - Re: [PATCH v2 1/1] kasan: Add memzero init for unaligned size under SLUB debug

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1147252f497e5529de8215486b184af649ac0a0e.camel@mediatek.com>
Date:   Mon, 28 Jun 2021 14:19:33 +0800
From:   Yee Lee <yee.lee@...iatek.com>
To:     Andrey Konovalov <andreyknvl@...il.com>
CC:     <wsd_upstream@...iatek.com>,
        Andrey Ryabinin <ryabinin.a.a@...il.com>,
        Alexander Potapenko <glider@...gle.com>,
        Dmitry Vyukov <dvyukov@...gle.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Matthias Brugger" <matthias.bgg@...il.com>,
        "open list:KASAN" <kasan-dev@...glegroups.com>,
        "open list:MEMORY MANAGEMENT" <linux-mm@...ck.org>,
        open list <linux-kernel@...r.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-arm-kernel@...ts.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@...ts.infradead.org>
Subject: Re: [PATCH v2 1/1] kasan: Add memzero init for unaligned size under
 SLUB debug

On Fri, 2021-06-25 at 17:03 +0300, Andrey Konovalov wrote:
> On Thu, Jun 24, 2021 at 2:26 PM <yee.lee@...iatek.com> wrote:
> > 
> > From: Yee Lee <yee.lee@...iatek.com>
> > 
> > Issue: when SLUB debug is on, hwtag kasan_unpoison() would
> > overwrite
> > the redzone of object with unaligned size.
> > 
> > An additional memzero_explicit() path is added to replacing init by
> > hwtag instruction for those unaligned size at SLUB debug mode.
> > 
> > Signed-off-by: Yee Lee <yee.lee@...iatek.com>
> > ---
> >  mm/kasan/kasan.h | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/mm/kasan/kasan.h b/mm/kasan/kasan.h
> > index 8f450bc28045..d1054f35838f 100644
> > --- a/mm/kasan/kasan.h
> > +++ b/mm/kasan/kasan.h
> > @@ -387,6 +387,12 @@ static inline void kasan_unpoison(const void
> > *addr, size_t size, bool init)
> > 
> >         if (WARN_ON((unsigned long)addr & KASAN_GRANULE_MASK))
> >                 return;
> > +#if IS_ENABLED(CONFIG_SLUB_DEBUG)
> 
> Is this an issue only with SLUB? SLAB also uses redzones.
As I known, hw-tag kasan only works with SLUB.

> 
> > +       if (init && ((unsigned long)size & KASAN_GRANULE_MASK)) {
> 
> This needs a comment along the lines of:
> 
> /* Explicitly initialize the memory with the precise object size to
> avoid overwriting the SLAB redzone. This disables initialization in
> the arch code and may thus lead to performance penalty. The penalty
> is
> accepted since SLAB redzones aren't enabled in production builds. */
Sure, will work on this.
> 
> > +               init = false;
> > +               memzero_explicit((void *)addr, size);
> > +       }
> > +#endif
> >         size = round_up(size, KASAN_GRANULE_SIZE);
> > 
> >         hw_set_mem_tag_range((void *)addr, size, tag, init);
> > --
> > 2.18.0
> >