[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <YNlrJVWaz831cQas@infradead.org>
Date: Mon, 28 Jun 2021 07:24:37 +0100
From: Christoph Hellwig <hch@...radead.org>
To: Matthew Wilcox <willy@...radead.org>
Cc: Christoph Hellwig <hch@...radead.org>, akpm@...ux-foundation.org,
linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 17/46] mm/memcg: Convert
mem_cgroup_track_foreign_dirty_slowpath() to folio
On Thu, Jun 24, 2021 at 06:37:47PM +0100, Matthew Wilcox wrote:
> On Wed, Jun 23, 2021 at 10:21:26AM +0200, Christoph Hellwig wrote:
> > Looks good,
> >
> > Reviewed-by: Christoph Hellwig <hch@....de>
> >
> > Although I wish we could come up with a shorter name for
> > mem_cgroup_track_foreign_dirty_slowpath somehow..
>
> It is quite grotesque!
>
> How about folio_track_foreign_writeback() as a replacement name for
> mem_cgroup_track_foreign_dirty() and have it call
> __folio_track_foreign_writeback()?
>
> Although 'foreign' tends to be used in MM to mean "wrong NUMA node",
> so maybe that's misleading. folio_track_dirty_cgroup()?
> folio_mark_dirty_cgroup()? (the last to be read in context of
> __set_page_dirty() being renamed to __folio_mark_dirty())
That all sounds reasonable to me, hopefully someone more attached to
this code can pick one.
Powered by blists - more mailing lists