linux-kernel - Re: usb: host: Reduce xhci_handshake timeout in xhci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YNlxzj7KXG43Uyrp@kroah.com>
Date:   Mon, 28 Jun 2021 08:53:02 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Jung Daehwan <dh10.jung@...sung.com>
Cc:     Mathias Nyman <mathias.nyman@...el.com>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: usb: host: Reduce xhci_handshake timeout in xhci_reset

On Mon, Jun 28, 2021 at 11:25:48AM +0900, Jung Daehwan wrote:
> On Tue, Jun 22, 2021 at 09:56:20PM +0200, Greg Kroah-Hartman wrote:
> > On Tue, Jun 22, 2021 at 08:24:56PM +0900, Daehwan Jung wrote:
> > > It seems 10 secs timeout is too long in general case. A core would wait for
> > > 10 secs without doing other task and it can be happended on every device.
> > 
> > Only if the handshake does not come back sooner, right?
> 
> Yes, right.
> 
> > What is causing your device to timeout here?
> 
> Host Controller doesn't respond handshake. I don't know why and I ask HW team
> to debug it.

Please work to fix your hardware, that feels like the root of the
problem here.  If you require the timeout for xhci_reset() to happen,
then how do you know that the hardware really did reset properly in the
reduced amount of time you just provided?

thanks,

greg k-h