linux-kernel - Re: [PATCH v5 2/4] fpga: add FPGA_MGR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17e69761-9922-b3f2-5bd7-e29190f0b72c@silicom.dk>
Date:   Mon, 28 Jun 2021 09:35:38 +0200
From:   Martin Hundebøll <mhu@...icom.dk>
To:     trix@...hat.com, mdf@...nel.org, hao.wu@...el.com,
        michal.simek@...inx.com
Cc:     linux-fpga@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v5 2/4] fpga: add FPGA_MGR_REIMAGE flag

On 25/06/2021 21.58, trix@...hat.com wrote:
> From: Tom Rix <trix@...hat.com>
> 
> If this flag is set the reimage ops will be used otherwise the
> reconfig ops will be used to write the image
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>   include/linux/fpga/fpga-mgr.h | 3 +++
>   1 file changed, 3 insertions(+)
> 
> diff --git a/include/linux/fpga/fpga-mgr.h b/include/linux/fpga/fpga-mgr.h
> index 53f9402d6aa17..0791e22b07f88 100644
> --- a/include/linux/fpga/fpga-mgr.h
> +++ b/include/linux/fpga/fpga-mgr.h
> @@ -67,12 +67,15 @@ enum fpga_mgr_states {
>    * %FPGA_MGR_BITSTREAM_LSB_FIRST: SPI bitstream bit order is LSB first
>    *
>    * %FPGA_MGR_COMPRESSED_BITSTREAM: FPGA bitstream is compressed
> + *
> + * %FPGA_MGR_REIMAGE: Reimage the whole card, fpga bs and other device fw
>    */
>   #define FPGA_MGR_PARTIAL_RECONFIG	BIT(0)
>   #define FPGA_MGR_EXTERNAL_CONFIG	BIT(1)
>   #define FPGA_MGR_ENCRYPTED_BITSTREAM	BIT(2)
>   #define FPGA_MGR_BITSTREAM_LSB_FIRST	BIT(3)
>   #define FPGA_MGR_COMPRESSED_BITSTREAM	BIT(4)
> +#define FPGA_MGR_REIMAGE                BIT(5)

Are you mixing spaces with tabs here?

// Martin