linux-kernel - Re: [PATCH] soc/tegra: Fix an error handling path in 'tegra_powergate_power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52f72ce4-a630-af2f-858e-488e4dd7d9cf@nvidia.com>
Date:   Mon, 28 Jun 2021 09:28:27 +0100
From:   Jon Hunter <jonathanh@...dia.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        <thierry.reding@...il.com>, <digetx@...il.com>,
        <ulf.hansson@...aro.org>, <maz@...nel.org>,
        <gustavoars@...nel.org>, <jckuo@...dia.com>
CC:     <linux-tegra@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] soc/tegra: Fix an error handling path in
 'tegra_powergate_power_up()'


On 27/06/2021 16:54, Christophe JAILLET wrote:
> If an error occurs after a successful 'tegra_powergate_enable_clocks()'
> call, it must be undone by a 'tegra_powergate_disable_clocks()' call, as
> already done in the below and above error handling paths of this function.
> 
> Update the 'goto' to branch at the correct place of the error handling
> path.
> 
> Fixes: a38045121bf4 ("soc/tegra: pmc: Add generic PM domain support")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> /!\ This patch is speculative /!\
> Review with care.
> ---
>  drivers/soc/tegra/pmc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/tegra/pmc.c b/drivers/soc/tegra/pmc.c
> index ea62f84d1c8b..b8ef9506f3de 100644
> --- a/drivers/soc/tegra/pmc.c
> +++ b/drivers/soc/tegra/pmc.c
> @@ -782,7 +782,7 @@ static int tegra_powergate_power_up(struct tegra_powergate *pg,
>  
>  	err = reset_control_deassert(pg->reset);
>  	if (err)
> -		goto powergate_off;
> +		goto disable_clks;
>  
>  	usleep_range(10, 20);


Thanks for the fix.

Reviewed-by: Jon Hunter <jonathanh@...dia.com>

Cheers
Jon

-- 
nvpublic