linux-kernel - Re: [PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210628101205.bul2iwwljxtd24tb@gilmour>
Date:   Mon, 28 Jun 2021 12:12:05 +0200
From:   Maxime Ripard <maxime@...no.tech>
To:     Laurent Pinchart <laurent.pinchart@...asonboard.com>
Cc:     Jonathan Liu <net147@...il.com>,
        Jagan Teki <jagan@...rulasolutions.com>,
        Andrzej Hajda <a.hajda@...sung.com>,
        Neil Armstrong <narmstrong@...libre.com>,
        Sandy Huang <hjc@...k-chips.com>,
        Heiko Stubner <heiko@...ech.de>,
        Yannick Fertre <yannick.fertre@...com>,
        Philippe Cornu <philippe.cornu@...com>,
        Benjamin Gaignard <benjamin.gaignard@...aro.org>,
        Vincent Abriou <vincent.abriou@...com>,
        Jernej Skrabec <jernej.skrabec@...l.net>,
        Jonas Karlman <jonas@...boo.se>,
        Sam Ravnborg <sam@...nborg.org>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        linux-amarula <linux-amarula@...rulasolutions.com>
Subject: Re: [PATCH] drm/bridge: dw-mipi-dsi: Move drm_bridge_add into probe

Hi,

On Thu, Jun 24, 2021 at 03:51:05PM +0300, Laurent Pinchart wrote:
> CC'ing Maxime Ripard.
> 
> Maxime, is this similar to the issue we've recently discussed with the
> VC4 DSI encoder ?
> 
> On Thu, Jun 24, 2021 at 10:39:48PM +1000, Jonathan Liu wrote:
> > On Thu, 24 Jun 2021 at 22:34, Jagan Teki wrote:
> > > On Fri, Jun 18, 2021 at 6:40 PM Jonathan Liu wrote:
> > > > On Wed, 3 Feb 2021 at 09:13, Jagan Teki wrote:
> > > > > @@ -1167,6 +1151,20 @@ __dw_mipi_dsi_probe(struct platform_device *pdev,
> > > > >         dw_mipi_dsi_debugfs_init(dsi);
> > > > >         pm_runtime_enable(dev);
> > > > >
> > > > > +       ret = drm_of_find_panel_or_bridge(dev->of_node, 1, 0,
> > > > > +                                         &panel, &bridge);
> > > > > +       if (ret)
> > > > > +               return ERR_PTR(ret);
> > > >
> > > > On RK3399 if the error is EPROBE_DEFER, __dw_mipi_dsi_probe can be
> > > > called again and result in the following errors:
> > > > [    0.717589] debugfs: Directory 'ff960000.mipi' with parent '/' already present!
> > > > [    0.717601] dw-mipi-dsi-rockchip ff960000.mipi: failed to create debugfs root
> > > > [    0.717606] dw-mipi-dsi-rockchip ff960000.mipi: Unbalanced pm_runtime_enable!
> > >
> > > Is this when you test bridge on rk3399 or panel?
> > 
> > MIPI-DSI to LVDS bridge.

It looks more like a driver that doesn't free its resources properly on EPROBE_DEFER?

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)