linux-kernel - Re: [PATCH] gfs2: Fix error handling in init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAHc6FU5B_bkLyU5T5KEsOr_ds0E30MVyhVdB5ck43n9tg3PRbA@mail.gmail.com>
Date:   Mon, 28 Jun 2021 14:23:47 +0200
From:   Andreas Gruenbacher <agruenba@...hat.com>
To:     Jing Xiangfeng <jingxiangfeng@...wei.com>
Cc:     Bob Peterson <rpeterso@...hat.com>, Abhijith Das <adas@...hat.com>,
        cluster-devel <cluster-devel@...hat.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gfs2: Fix error handling in init_statfs()

Hi Jing,

On Mon, Jun 28, 2021 at 1:22 PM Jing Xiangfeng <jingxiangfeng@...wei.com> wrote:
> In an error path of init_statfs(), it calls iput to put pn which has been
> put. Jump to correct label to fix it.

thanks for your patch. This looks okay, but I'd rather set pn to NULL
after the iput instead. Since iput(NULL) is a no-op, we'll end up with
the same result.

Andreas