linux-kernel - Re: [PATCH] scsi: aic7xxx: Fix unintentional sign extension issue on left shift of u8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <162493961194.16549.11024974338962781518.b4-ty@oracle.com>
Date:   Tue, 29 Jun 2021 00:10:06 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     linux-scsi@...r.kernel.org, Colin King <colin.king@...onical.com>,
        Hannes Reinecke <hare@...e.com>,
        "James E . J . Bottomley" <jejb@...ux.ibm.com>
Cc:     "Martin K . Petersen" <martin.petersen@...cle.com>,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] scsi: aic7xxx: Fix unintentional sign extension issue on left shift of u8

On Mon, 21 Jun 2021 16:17:27 +0100, Colin King wrote:

> The shifting of the u8 integer returned fom ahc_inb(ahc, port+3) by
> 24 bits to the left will be promoted to a 32 bit signed int and then
> sign-extended to a u64. In the event that the top bit of the u8
> is set then all then all the upper 32 bits of the u64 end up as
> also being set because of the sign-extension. Fix this by
> casting the u8 values to a u64 before the 24 bit left shift.
> 
> [...]

Applied to 5.14/scsi-queue, thanks!

[1/1] scsi: aic7xxx: Fix unintentional sign extension issue on left shift of u8
      https://git.kernel.org/mkp/scsi/c/332a9dd1d86f

-- 
Martin K. Petersen	Oracle Linux Engineering