linux-kernel - Re: [PATCH v4 2/2] MIPS: Loongson64: Add pm block node for Loongson-2K1000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 29 Jun 2021 09:04:10 +0800
From:   zhangqing <zhangqing@...ngson.cn>
To:     Sergei Shtylyov <sergei.shtylyov@...il.com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Rob Herring <robh+dt@...nel.org>,
        Jiaxun Yang <jiaxun.yang@...goat.com>,
        Huacai Chen <chenhuacai@...nel.org>
Cc:     devicetree@...r.kernel.org, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 2/2] MIPS: Loongson64: Add pm block node for
 Loongson-2K1000



On 06/29/2021 12:03 AM, Sergei Shtylyov wrote:
> Hello!
>
> On 6/28/21 6:13 PM, Qing Zhang wrote:
>
>> The module is now supported, enable it.
>>
>> Signed-off-by: Qing Zhang <zhangqing@...ngson.cn>
>> ---
>>
>> v3-v4:
>> No change
>>
>> Signed-off-by: Qing Zhang <zhangqing@...ngson.cn>
>> ---
>>   arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
>> index 569e814def83..e31176ac0ac2 100644
>> --- a/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
>> +++ b/arch/mips/boot/dts/loongson/loongson64-2k1000.dtsi
>> @@ -101,6 +101,15 @@ uart0: serial@...00000 {
>>   			no-loopback-test;
>>   		};
>>   
>> +		pm: power-controller {
>> +			device_type = "power management";
>> +			compatible = "loongson, reset-controller";
>     No spaces allowed here, AFAIK.
>
>> +			reg = <0 0x1fe0700c 0 0x8>,
>> +				<0 0x1fe07014 0 0x8>,
>> +				<0 0x1fe07030 0 0x8>;
>     Better keep those aligned...
Hi Sergei :-)

enm...

Will fix in next reversion.

Thanks.

-Qing
>
>> +			reg-names = "pm1_sts", "pm1_cnt", "rst_cnt";
>> +		};
>> +
> [...]
>
> MBR, Sergei