linux-kernel - Re: [PATCH net-next v3 1/2] once: implement DO_ONCE_LITE for non-fast-path "do once" functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YNrM1neBRdjkRf02@alley>
Date:   Tue, 29 Jun 2021 09:33:42 +0200
From:   Petr Mladek <pmladek@...e.com>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Tanner Love <tannerlove.kernel@...il.com>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Mahesh Bandewar <maheshb@...gle.com>,
        "Darrick J . Wong" <djwong@...nel.org>,
        Arnd Bergmann <arnd@...db.de>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        John Ogness <john.ogness@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Andrii Nakryiko <andriin@...com>,
        Antoine Tenart <atenart@...nel.org>,
        Alexander Lobakin <alobakin@...me>,
        Wei Wang <weiwan@...gle.com>, Taehee Yoo <ap420073@...il.com>,
        Yunsheng Lin <linyunsheng@...wei.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Tanner Love <tannerlove@...gle.com>
Subject: Re: [PATCH net-next v3 1/2] once: implement DO_ONCE_LITE for
 non-fast-path "do once" functionality

On Mon 2021-06-28 11:14:46, Steven Rostedt wrote:
> On Mon, 28 Jun 2021 09:50:06 -0400
> Tanner Love <tannerlove.kernel@...il.com> wrote:
> 
> > Certain uses of "do once" functionality reside outside of fast path,
> > and so do not require jump label patching via static keys, making
> > existing DO_ONCE undesirable in such cases.
> > 
> > Replace uses of __section(".data.once") with DO_ONCE_LITE(_IF)?
> 
> I hate the name "_LITE" but can't come up with something better.
> 
> Maybe: DO_ONCE_SLOW() ??

Or rename the original DO_ONCE() to DO_ONCE_FAST() because it is
more tricky to be fast. And call the "normal" implementation DO_ONCE().

> Anyway, besides my bike-shedding comment above...

Same here :-)

Acked-by: Petr Mladek <pmladek@...e.com>

Best Regards,
Petr