linux-kernel - Re: [PATCH 3/9] sections: Move and rename core_kernel_data() to is_kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210628210538.0fdded1c@oasis.local.home>
Date:   Mon, 28 Jun 2021 21:05:38 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Kefeng Wang <wangkefeng.wang@...wei.com>
Cc:     Arnd Bergmann <arnd@...db.de>, <linux-arch@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...hat.com>,
        "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH 3/9] sections: Move and rename core_kernel_data() to
 is_kernel_data()

On Sat, 26 Jun 2021 15:34:33 +0800
Kefeng Wang <wangkefeng.wang@...wei.com> wrote:

> Move core_kernel_data() into sections.h and rename it to
> is_kernel_data(), also make it return bool value, then
> update all the callers.

Removing the "core" part of "core_kernel_data()" is misleading. As
modules can have kernel data, but this will return false on module data
(as it should). This is similar to core_kernel_text() which this series
doesn't seem to touch.

I'd like to keep the "core" in the name which makes it obvious this is
not about module data, and if someone were to make it about module
data, it will break ftrace synchronization.

-- Steve