linux-kernel - [PATCH] dmaengine: pl330: Typecast with enum to fix the coverity warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210629103710.24828-1-harini.katakam@xilinx.com>
Date:   Tue, 29 Jun 2021 16:07:10 +0530
From:   Harini Katakam <harini.katakam@...inx.com>
To:     <vkoul@...nel.org>
CC:     <dmaengine@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <harinikatakamlinux@...il.com>, <michal.simek@...inx.com>,
        <harini.katakam@...inx.com>, <radhey.shyam.pandey@...inx.com>,
        <shravya.kumbham@...inx.com>
Subject: [PATCH] dmaengine: pl330: Typecast with enum to fix the coverity warning

From: Shravya Kumbham <shravya.kumbham@...inx.com>

Typecast the flags and flg variables with (enum dma_ctrl_flags) in
pl330_prep_dma_cyclic, pl330_prep_dma_memcpy and pl330_prep_slave_sg
functions to fix the coverity warning.

Addresses-Coverity: Event mixed_enum_type.
Signed-off-by: Shravya Kumbham <shravya.kumbham@...inx.com>
Signed-off-by: Harini Katakam <harini.katakam@...inx.com>
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>
---
 drivers/dma/pl330.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/dma/pl330.c b/drivers/dma/pl330.c
index 110de8a60058..35afbad2e1a7 100644
--- a/drivers/dma/pl330.c
+++ b/drivers/dma/pl330.c
@@ -2752,7 +2752,7 @@ static struct dma_async_tx_descriptor *pl330_prep_dma_cyclic(
 		return NULL;
 
 	pch->cyclic = true;
-	desc->txd.flags = flags;
+	desc->txd.flags = (enum dma_ctrl_flags)flags;
 
 	return &desc->txd;
 }
@@ -2804,7 +2804,7 @@ pl330_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dst,
 
 	desc->bytes_requested = len;
 
-	desc->txd.flags = flags;
+	desc->txd.flags = (enum dma_ctrl_flags)flags;
 
 	return &desc->txd;
 }
@@ -2889,7 +2889,7 @@ pl330_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl,
 	}
 
 	/* Return the last desc in the chain */
-	desc->txd.flags = flg;
+	desc->txd.flags = (enum dma_ctrl_flags)flg;
 	return &desc->txd;
 }
 
-- 
2.17.1