linux-kernel - Re: [PATCH -next] drm/radeon: Add the missed drm_gem_object_put() in radeon_user_framebuffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5ff91e15-6014-bc72-40ca-3fa8b834f692@amd.com>
Date:   Tue, 29 Jun 2021 13:42:18 +0200
From:   Christian König <christian.koenig@....com>
To:     Jing Xiangfeng <jingxiangfeng@...wei.com>,
        alexander.deucher@....com, airlied@...ux.ie, daniel@...ll.ch
Cc:     amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] drm/radeon: Add the missed drm_gem_object_put() in
 radeon_user_framebuffer_create()

Am 29.06.21 um 13:44 schrieb Jing Xiangfeng:
> radeon_user_framebuffer_create() misses to call drm_gem_object_put() in
> an error path. Add the missed function call to fix it.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@...wei.com>

I'm pretty sure that I already reviewed the same patch a few weeks ago, 
but it looks like it never went upstream.

Reviewed-by: Christian König <christian.koenig@....com>

Maybe add CC: stable as well?

Regards,
Christian.

> ---
>   drivers/gpu/drm/radeon/radeon_display.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> index 652af7a134bd..1d03ec763604 100644
> --- a/drivers/gpu/drm/radeon/radeon_display.c
> +++ b/drivers/gpu/drm/radeon/radeon_display.c
> @@ -1325,6 +1325,7 @@ radeon_user_framebuffer_create(struct drm_device *dev,
>   	/* Handle is imported dma-buf, so cannot be migrated to VRAM for scanout */
>   	if (obj->import_attach) {
>   		DRM_DEBUG_KMS("Cannot create framebuffer from imported dma_buf\n");
> +		drm_gem_object_put(obj);
>   		return ERR_PTR(-EINVAL);
>   	}
>