linux-kernel - Re: [PATCH] fs: ntfs: super: added return error value while map failed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8c9ab967-432a-5912-3e8e-25cae5b9acbf@gmx.com>
Date:   Tue, 29 Jun 2021 20:30:47 +0800
From:   Qu Wenruo <quwenruo.btrfs@....com>
To:     lijian_8010a29@....com, clm@...com, josef@...icpanda.com,
        dsterba@...e.com
Cc:     linux-btrfs@...r.kernel.org, linux-kernel@...r.kernel.org,
        lijian <lijian@...ong.com>
Subject: Re: [PATCH] fs: ntfs: super: added return error value while map
 failed

Wrong subject, it's not ntfs.

On 2021/6/29 下午5:53, lijian_8010a29@....com wrote:
> From: lijian <lijian@...ong.com>

Still, you guys should try to send from your yulong.com mail box, not 163.

>
> When lookup_extent_mapping failed, should return '-ENOENT'.
>
> Signed-off-by: lijian <lijian@...ong.com>

Some maintainer is OK with name like all lower letters, but at least to
my eyes, Li Jian <lijian@...ong.com> is much easier to read.

Thanks,
Qu

> ---
>   fs/btrfs/extent_map.c | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/extent_map.c b/fs/btrfs/extent_map.c
> index 4a8e02f7b6c7..e9d9f2bfc11d 100644
> --- a/fs/btrfs/extent_map.c
> +++ b/fs/btrfs/extent_map.c
> @@ -305,8 +305,10 @@ int unpin_extent_cache(struct extent_map_tree *tree, u64 start, u64 len,
>
>   	WARN_ON(!em || em->start != start);
>
> -	if (!em)
> +	if (!em) {
> +		ret = -ENOENT;
>   		goto out;
> +	}
>
>   	em->generation = gen;
>   	clear_bit(EXTENT_FLAG_PINNED, &em->flags);
>