[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20210629022556.3985106-6-sunnanyong@huawei.com>
Date: Tue, 29 Jun 2021 10:25:55 +0800
From: Nanyong Sun <sunnanyong@...wei.com>
To: <konishi.ryusuke@...il.com>
CC: <linux-nilfs@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<sunnanyong@...wei.com>, <wangkefeng.wang@...wei.com>
Subject: [PATCH 5/6] nilfs2: fix memory leak in nilfs_sysfs_create_snapshot_group
If kobject_init_and_add returns with error, kobject_put() is needed
here to avoid memory leak, because kobject_init_and_add may return
error without freeing the memory associated with the kobject it allocated.
Signed-off-by: Nanyong Sun <sunnanyong@...wei.com>
---
fs/nilfs2/sysfs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/nilfs2/sysfs.c b/fs/nilfs2/sysfs.c
index d989e6500bd7..5ba87573ad3b 100644
--- a/fs/nilfs2/sysfs.c
+++ b/fs/nilfs2/sysfs.c
@@ -195,9 +195,9 @@ int nilfs_sysfs_create_snapshot_group(struct nilfs_root *root)
}
if (err)
- return err;
+ kobject_put(&root->snapshot_kobj);
- return 0;
+ return err;
}
void nilfs_sysfs_delete_snapshot_group(struct nilfs_root *root)
--
2.18.0.huawei.25
Powered by blists - more mailing lists