linux-kernel - Re: [PATCH v5] rtc: pcf2127: handle timestamp interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210629145221.GF81946@suse.de>
Date:   Tue, 29 Jun 2021 16:52:21 +0200
From:   Mian Yousaf Kaukab <ykaukab@...e.de>
To:     Bruno Thomsen <bruno.thomsen@...il.com>
Cc:     Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-rtc@...r.kernel.org,
        open list <linux-kernel@...r.kernel.org>, biwen.li@....com,
        Bruno Thomsen <bth@...strup.com>
Subject: Re: [PATCH v5] rtc: pcf2127: handle timestamp interrupts

On Mon, Jun 28, 2021 at 11:42:03AM +0200, Bruno Thomsen wrote:
> Hi again,
> 
> Forgot another important comment. After you moved code to
> pcf2127_rtc_ts_read() it seems to lookup pcf2127 struct wrong.
> 
> struct pcf2127 *pcf2127 = dev_get_drvdata(dev->parent);
Good catch! I will fix it by calling pcf2127_rtc_ts_read(dev->parent).
dev_get_drvdata(dev) is correct from the irq path.
> 
> /Bruno
> 
BR,
Yousaf