linux-kernel - RE: [PATCH 2/2] clk: lmk04832: Use of match table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YQBPR0101MB1811DDE8C4D8802A082E77DFD8029@YQBPR0101MB1811.CANPRD01.PROD.OUTLOOK.COM>
Date:   Tue, 29 Jun 2021 15:03:49 +0000
From:   Liam Beguin <lvb@...hos.com>
To:     Stephen Boyd <sboyd@...nel.org>,
        Michael Turquette <mturquette@...libre.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-clk@...r.kernel.org" <linux-clk@...r.kernel.org>,
        kernel test robot <lkp@...el.com>,
        "liambeguin@...il.com" <liambeguin@...il.com>
Subject: RE: [PATCH 2/2] clk: lmk04832: Use of match table



> -----Original Message-----
> From: Stephen Boyd <sboyd@...nel.org>
> Sent: June 29, 2021 2:08 AM
> To: Michael Turquette <mturquette@...libre.com>; Stephen Boyd
> <sboyd@...nel.org>
> Cc: linux-kernel@...r.kernel.org; linux-clk@...r.kernel.org; kernel test
> robot <lkp@...el.com>; Liam Beguin <lvb@...hos.com>
> Subject: [PATCH 2/2] clk: lmk04832: Use of match table
> 
> Presumably we want to use this match table so add a module device table
> and set the driver match pointer appropriately.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Cc: Liam Beguin <lvb@...hos.com>
> Fixes: 3bc61cfd6f4a ("clk: add support for the lmk04832")
> Signed-off-by: Stephen Boyd <sboyd@...nel.org>

Reviewed-by: Liam Beguin <lvb@...hos.com>

> ---
>  drivers/clk/clk-lmk04832.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/clk/clk-lmk04832.c b/drivers/clk/clk-lmk04832.c
> index 0cd76e626c3d..c1095e733220 100644
> --- a/drivers/clk/clk-lmk04832.c
> +++ b/drivers/clk/clk-lmk04832.c
> @@ -1573,18 +1573,20 @@ static int lmk04832_remove(struct spi_device
> *spi)
>  }
>  static const struct spi_device_id lmk04832_id[] = {
>  	{ "lmk04832", LMK04832 },
> -	{},
> +	{}
>  };
>  MODULE_DEVICE_TABLE(spi, lmk04832_id);
> 
>  static const struct of_device_id lmk04832_of_id[] = {
>  	{ .compatible = "ti,lmk04832" },
> -	{},
> +	{}
>  };
> +MODULE_DEVICE_TABLE(of, lmk04832_of_id);
> 
>  static struct spi_driver lmk04832_driver = {
>  	.driver = {
>  		.name	= "lmk04832",
> +		.of_match_table = lmk04832_of_id,
>  	},
>  	.probe		= lmk04832_probe,
>  	.remove		= lmk04832_remove,
> --
> https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
> https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git