linux-kernel - Re: [PATCH v10 2/5] regulator: hi6421v600-regulator: fix platform drvdata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210629151101.GB4613@sirena.org.uk>
Date:   Tue, 29 Jun 2021 16:11:01 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linuxarm@...wei.com, mauro.chehab@...wei.com,
        Axel Lin <axel.lin@...ics.com>,
        Lee Jones <lee.jones@...aro.org>,
        Arnd Bergmann <arnd@...db.de>,
        Liam Girdwood <lgirdwood@...il.com>,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [PATCH v10 2/5] regulator: hi6421v600-regulator: fix platform
 drvdata

On Tue, Jun 29, 2021 at 12:31:28PM +0200, Mauro Carvalho Chehab wrote:

> platform drvdata can't be used inside the regulator driver,
> as this is already used by the MFD and SPMI drivers.

Can you clarify what exactly is using which platform drvdata already?
This all feels very confused and I can't tell what the problem that's
being fixed is, if it's a real issue or how this fixes it.

>  drivers/misc/hi6421v600-irq.c               |  9 ++--
>  drivers/regulator/hi6421v600-regulator.c    | 49 +++++++++++----------
>  drivers/staging/hikey9xx/hi6421-spmi-pmic.c | 18 +++-----
>  include/linux/mfd/hi6421-spmi-pmic.h        | 25 -----------

I'm especially nervous about the core driver still being in staging
perhaps meaning there's some issue with it doing odd and confusing
things.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)