linux-kernel - Re: [PATCH 06/17] mshv: SynIC port and connection hypercalls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Jun 2021 12:19:52 -0400
From:   Vineeth Pillai <viremana@...ux.microsoft.com>
To:     Wei Liu <wei.liu@...nel.org>,
        Vitaly Kuznetsov <vkuznets@...hat.com>
Cc:     Nuno Das Neves <nunodasneves@...ux.microsoft.com>,
        Sunil Muthuswamy <sunilmut@...rosoft.com>,
        Michael Kelley <mikelley@...rosoft.com>,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, linux-hyperv@...r.kernel.org
Subject: Re: [PATCH 06/17] mshv: SynIC port and connection hypercalls


On 6/29/2021 8:55 AM, Wei Liu wrote:
>
>>> +		if (status != HV_STATUS_INSUFFICIENT_MEMORY) {
>>> +			pr_err("%s: %s\n",
>>> +			       __func__, hv_status_to_string(status));
>>> +			ret = -hv_status_to_errno(status);
>> In Nuno's "x86/hyperv: convert hyperv statuses to linux error codes"
>> patch, hv_status_to_errno() already returns negatives:
> Yes, this needs to be fixed otherwise one of the following patch has the
> error handling check reversed.
Sorry I missed replying to this. Thanks Vitaly and Wei, I will have this 
fixed in the
next iteration.

~Vineeth