linux-kernel - Re: [PATCH 1/2] objtool: Check for gelf_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210629171224.jhlqyyb3lus323o3@treble>
Date:   Tue, 29 Jun 2021 12:12:24 -0500
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     Michael Forney <mforney@...rney.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] objtool: Check for gelf_update_rel[a] failures

On Mon, Jun 28, 2021 at 10:24:38AM +0200, Peter Zijlstra wrote:
> On Mon, Jun 28, 2021 at 12:52:07AM -0700, Michael Forney wrote:
> > On 2021-05-08, Michael Forney <mforney@...rney.org> wrote:
> > > Otherwise, if these fail we end up with garbage data in the
> > > .rela.orc_unwind_ip section, leading to errors like
> > >
> > >   ld: fs/squashfs/namei.o: bad reloc symbol index (0x7f16 >= 0x12) for
> > > offset 0x7f16d5c82cc8 in section `.orc_unwind_ip'
> > >
> > > Signed-off-by: Michael Forney <mforney@...rney.org>
> > 
> > Ping on these patches.
> 
> Josh, I forever forget which libelf versions we're supposed to support,
> 
> But these patches do look reasonable to me, wdyt?

Looks ok to me.  Let me run them through some testing.

-- 
Josh