linux-kernel - Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c7f0989-305b-fe4c-63d1-966043c5d2f2@intel.com>
Date:   Tue, 29 Jun 2021 11:04:10 +0800
From:   Jie Deng <jie.deng@...el.com>
To:     Wolfram Sang <wsa@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Linux I2C <linux-i2c@...r.kernel.org>,
        virtualization@...ts.linux-foundation.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        conghui.chen@...el.com, kblaiech@...lanox.com,
        jarkko.nikula@...ux.intel.com,
        Sergey Semin <Sergey.Semin@...kalelectronics.ru>,
        Mike Rapoport <rppt@...nel.org>, loic.poulain@...aro.org,
        Tali Perry <tali.perry1@...il.com>,
        Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        yu1.wang@...el.com, shuo.a.liu@...el.com,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Stefan Hajnoczi <stefanha@...hat.com>,
        Paolo Bonzini <pbonzini@...hat.com>
Subject: Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver

On 2021/6/28 22:58, Wolfram Sang wrote:
> If adding support incrementally works for such an interface, this makes
> sense as well.
>
> So, where are we? As I understand, this v10 does not support I2C
> transactions (or I2C_RDWR as you said). But you want to support all
> clients. So, this doesn't match, or?

I hope we can have a minimum working driver get merged first so that we 
can have a base.

The v10 has three remaining problems:

     1. To remove vi->adap.class = I2C_CLASS_DEPRECATED; (already 
confirmed by Wolfram)

     2. Use #ifdef CONFIG_PM_SLEEP to replace the "__maybe_unused" 
(already confirmed by Arnd)

     3. It seems the I2C core takes care of locking already, so is it 
safy to remove "struct mutex lock in struct virtio_i2c"?

         (Raised by Viresh, still need Wolfram's confirmation)

Regards,

Jie