linux-kernel - Re: [PATCH] x86/SGX: drop spurious kernel-doc notation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20210629202253.qwqpaqoauz4usgle@kernel.org>
Date:   Tue, 29 Jun 2021 23:22:53 +0300
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Randy Dunlap <rdunlap@...radead.org>
Cc:     linux-kernel@...r.kernel.org,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        linux-sgx@...r.kernel.org
Subject: Re: [PATCH] x86/SGX: drop spurious kernel-doc notation

On Sun, Jun 27, 2021 at 03:36:39PM -0700, Randy Dunlap wrote:
> Drop mistaken kernel-doc notation where plain C comments
> should be used instead.
> 
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Jarkko Sakkinen <jarkko@...nel.org>
> Cc: Dave Hansen <dave.hansen@...ux.intel.com>
> Cc: linux-sgx@...r.kernel.org

"x86/SGX" -> "x86/sgx"

Anyway,

Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@...nel.org>

> ---
>  arch/x86/kernel/cpu/sgx/encl.h  |    2 +-
>  arch/x86/kernel/cpu/sgx/encls.h |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux-next-20210625.orig/arch/x86/kernel/cpu/sgx/encl.h
> +++ linux-next-20210625/arch/x86/kernel/cpu/sgx/encl.h
> @@ -1,5 +1,5 @@
>  /* SPDX-License-Identifier: GPL-2.0 */
> -/**
> +/*
>   * Copyright(c) 2016-20 Intel Corporation.
>   *
>   * Contains the software defined data structures for enclaves.
> --- linux-next-20210625.orig/arch/x86/kernel/cpu/sgx/encls.h
> +++ linux-next-20210625/arch/x86/kernel/cpu/sgx/encls.h
> @@ -11,7 +11,7 @@
>  #include <asm/traps.h>
>  #include "sgx.h"
>  
> -/**
> +/*
>   * ENCLS_FAULT_FLAG - flag signifying an ENCLS return code is a trapnr
>   *
>   * ENCLS has its own (positive value) error codes and also generates
> 

/Jarkko