linux-kernel - Re: [PATCH] pstore/blk: Use "%lu" to format unsigned long

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <162500112137.438178.14586324457676666976.b4-ty@chromium.org>
Date:   Tue, 29 Jun 2021 14:12:05 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Tony Luck <tony.luck@...el.com>,
        Anton Vorontsov <anton@...msg.org>,
        Colin Cross <ccross@...roid.com>,
        Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Kees Cook <keescook@...omium.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pstore/blk: Use "%lu" to format unsigned long

On Tue, 29 Jun 2021 12:37:00 +0200, Geert Uytterhoeven wrote:
> On 32-bit:
> 
>     fs/pstore/blk.c: In function ‘__best_effort_init’:
>     include/linux/kern_levels.h:5:18: warning: format ‘%zu’ expects argument of type ‘size_t’, but argument 3 has type ‘long unsigned int’ [-Wformat=]
> 	5 | #define KERN_SOH "\001"  /* ASCII Start Of Header */
> 	  |                  ^~~~~~
>     include/linux/kern_levels.h:14:19: note: in expansion of macro ‘KERN_SOH’
>        14 | #define KERN_INFO KERN_SOH "6" /* informational */
> 	  |                   ^~~~~~~~
>     include/linux/printk.h:373:9: note: in expansion of macro ‘KERN_INFO’
>       373 |  printk(KERN_INFO pr_fmt(fmt), ##__VA_ARGS__)
> 	  |         ^~~~~~~~~
>     fs/pstore/blk.c:314:3: note: in expansion of macro ‘pr_info’
>       314 |   pr_info("attached %s (%zu) (no dedicated panic_write!)\n",
> 	  |   ^~~~~~~

Applied to for-next/pstore, thanks!

[1/1] pstore/blk: Use "%lu" to format unsigned long
      https://git.kernel.org/kees/c/c5d4fb2539ca

-- 
Kees Cook