linux-kernel - Re: [PATCH] IMA: remove -Wmissing-prototypes warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADLLry5D9T_icTSGOggb=3vJqYq9Qvq-WEhmfgJMCSGuPV0AAg@mail.gmail.com>
Date:   Wed, 30 Jun 2021 07:40:50 +0900
From:   Austin Kim <austindh.kim@...il.com>
To:     Mimi Zohar <zohar@...ux.ibm.com>
Cc:     dmitry.kasatkin@...il.com, James Morris <jmorris@...ei.org>,
        "Serge E. Hallyn" <serge@...lyn.com>,
        linux-integrity@...r.kernel.org,
        linux-security-module <linux-security-module@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        김동현 <austin.kim@....com>,
        Petko Manolov <petkan@...-labs.com>
Subject: Re: [PATCH] IMA: remove -Wmissing-prototypes warning

2021년 6월 29일 (화) 오후 11:30, Mimi Zohar <zohar@...ux.ibm.com>님이 작성:
>
> [Cc: Petko Manolov <petkan@...-labs.com>]
>
> Hi Austin,
>
> On Tue, 2021-06-29 at 14:50 +0100, Austin Kim wrote:
> > From: Austin Kim <austin.kim@....com>
> >
> > With W=1 build, the compiler throws warning message as below:
> >
> >    security/integrity/ima/ima_mok.c:24:12: warning:
> >    no previous prototype for ‘ima_mok_init’ [-Wmissing-prototypes]
> >        __init int ima_mok_init(void)
> >
> > Silence the warning by adding static keyword to ima_mok_init().
> >
> > Signed-off-by: Austin Kim <austin.kim@....com>
> > ---
> >  security/integrity/ima/ima_mok.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/security/integrity/ima/ima_mok.c b/security/integrity/ima/ima_mok.c
> > index 1e5c01916173..95cc31525c57 100644
> > --- a/security/integrity/ima/ima_mok.c
> > +++ b/security/integrity/ima/ima_mok.c
> > @@ -21,7 +21,7 @@ struct key *ima_blacklist_keyring;
> >  /*
> >   * Allocate the IMA blacklist keyring
> >   */
> > -__init int ima_mok_init(void)
> > +static __init int ima_mok_init(void)
> >  {
> >       struct key_restriction *restriction;
> >
>
> Thank you for the patch, which does fix the warning.   The .ima_mok
> keyring was removed a while ago.  With all the recent work on the
> system blacklist, I'm wondering if anyone is still using the IMA
> blacklist keyring or whether it should be removed as well.

Oh! Thanks for information.

>
> thanks,
>
> Mimi
>