linux-kernel - Re: [PATCH] mfd: mfd-core: Change "Failed to locate of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YNwuXWGe8am89Bn9@dell>
Date:   Wed, 30 Jun 2021 09:42:05 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Yunus Bas <Y.Bas@...tec.de>
Cc:     "stwiss.opensource@...semi.com" <stwiss.opensource@...semi.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd: mfd-core: Change "Failed to locate of_node" warning
 to debug

> No. This is not about DA9061 or it's mfd_cell-entries at all. My
> concern is about the general behaviour of the MFD-framework and how
> mfd_cell entries with compatibles are initialized.

I'm still not 100% sure I understand your use-case.

Let's take this back to basics.

What device are you trying to instantiate?  A DA9062 derivative?

> > Actually, this has served to highlight that your DTS is not correct.
> > 
> > Why are some devices represented in DT and some aren't?
> > 
> > If anything, I'm tempted to upgrade the info() print to warn().
> > 
> 
> Imagine only required parts of the MFD is connected to the designed
> system and unrequired parts are not. In that case, fully describing the
> MFD in the devicetree wouldn't represent the system at all.
> 
> Actually it would make more sense to check if mfd_cell-entries with
> compatibles are represented in the devicetree and add them after
> matching. This way the warning would serve it's purpose. What do you
> think of it?

I think the DT and MFD should match, so again, the way I currently
view this, doing it this way is just a different way to paper over the
cracks.

-- 
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog