linux-kernel - Re: [PATCH 1/3 v2] sh: fix kconfig unmet dependency warning for FRAME

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e1f5e3c2-67da-429a-4382-f011c8cd9655@physik.fu-berlin.de>
Date:   Wed, 30 Jun 2021 11:32:34 +0200
From:   John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
To:     Randy Dunlap <rdunlap@...radead.org>, linux-kernel@...r.kernel.org
Cc:     Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>, linux-sh@...r.kernel.org,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Matt Fleming <matt@...sole-pimps.org>,
        Matt Fleming <matt@...eblueprint.co.uk>
Subject: Re: [PATCH 1/3 v2] sh: fix kconfig unmet dependency warning for
 FRAME_POINTER

On 6/28/21 12:05 AM, Randy Dunlap wrote:
> FRAME_POINTER depends on DEBUG_KERNEL so DWARF_UNWINDER should
> depend on DEBUG_KERNEL before selecting FRAME_POINTER.
> 
> WARNING: unmet direct dependencies detected for FRAME_POINTER
>   Depends on [n]: DEBUG_KERNEL [=n] && (M68K || UML || SUPERH [=y]) || ARCH_WANT_FRAME_POINTERS [=n]
>   Selected by [y]:
>   - DWARF_UNWINDER [=y]
> 
> Fixes: bd353861c735 ("sh: dwarf unwinder support.")
> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
> Cc: Matt Fleming <matt@...sole-pimps.org>
> Cc: Matt Fleming <matt@...eblueprint.co.uk>
> Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp>
> Cc: Rich Felker <dalias@...c.org>
> Cc: linux-sh@...r.kernel.org
> Cc: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
> Cc: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> v2: drop Paul Mundt from Cc: list;
>     add this previously sent patch to the series;
>     add more Cc's;
> 
>  arch/sh/Kconfig.debug |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20210625.orig/arch/sh/Kconfig.debug
> +++ linux-next-20210625/arch/sh/Kconfig.debug
> @@ -57,6 +57,7 @@ config DUMP_CODE
>  
>  config DWARF_UNWINDER
>  	bool "Enable the DWARF unwinder for stacktraces"
> +	depends on DEBUG_KERNEL
>  	select FRAME_POINTER
>  	default n
>  	help
> 

Boot-tested on my SH-7785LCR without any issues (as expected).

Tested-by: John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@...ian.org
`. `'   Freie Universitaet Berlin - glaubitz@...sik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913