linux-kernel - Re: [PATCH v3 3/3] spi:amd:Fix for compilation error for non X86 platforms.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20210630124717.GE5106@sirena.org.uk>
Date:   Wed, 30 Jun 2021 13:47:17 +0100
From:   Mark Brown <broonie@...nel.org>
To:     Nehal Bakulchandra Shah <Nehal-Bakulchandra.shah@....com>
Cc:     linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel test robot <lkp@...el.com>,
        Shyam Sundar S K <Shyam-sundar.S-k@....com>,
        Liang Liang <liang.liang@....com>
Subject: Re: [PATCH v3 3/3] spi:amd:Fix for compilation error for non X86
 platforms.

On Wed, Jun 30, 2021 at 05:34:25PM +0530, Nehal Bakulchandra Shah wrote:

> Update the KConfig with dependency for ACPI as driver is only
> supported for x86 platform. This fixes the compilation error
> reported by kernel test robot.

If one of the earlier patches in the series fails to build you need to
fix that patch so you don't break bisection or cause people to spend
time finding errors in the earlier patches you fix later.

In any case this doesn't do what the commit log says, ACPI is supported
on at least arm64 so if you genuinely need an x86 dependency ACPI isn't
going to cut it and COMPILE_TEST means the driver will still be built on
everything.  I don't recall anything from 0day that looked like it was
anything to do with dependencies though.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)