linux-kernel - Re: [PATCH v3 1/2] kfence: move the size check to the beginning of __kfence

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANpmjNNWjks8fH6FBgjryEFm4z5vqn-ehyjXbcBj7x90hZpTjA@mail.gmail.com>
Date:   Wed, 30 Jun 2021 16:05:00 +0200
From:   Marco Elver <elver@...gle.com>
To:     Alexander Potapenko <glider@...gle.com>
Cc:     akpm@...ux-foundation.org, dvyukov@...gle.com,
        linux-kernel@...r.kernel.org, linux-mm@...ck.org,
        stable@...r.kernel.org, gregkh@...uxfoundation.org,
        jrdr.linux@...il.com
Subject: Re: [PATCH v3 1/2] kfence: move the size check to the beginning of __kfence_alloc()

On Wed, 30 Jun 2021 at 15:53, Alexander Potapenko <glider@...gle.com> wrote:
>
> Check the allocation size before toggling kfence_allocation_gate.
> This way allocations that can't be served by KFENCE will not result in
> waiting for another CONFIG_KFENCE_SAMPLE_INTERVAL without allocating
> anything.
>
> Suggested-by: Marco Elver <elver@...gle.com>
> Cc: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Dmitry Vyukov <dvyukov@...gle.com>
> Cc: Marco Elver <elver@...gle.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: stable@...r.kernel.org # 5.12+
> Signed-off-by: Alexander Potapenko <glider@...gle.com>

Reviewed-by: Marco Elver <elver@...gle.com>


> ---
>  mm/kfence/core.c | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/mm/kfence/core.c b/mm/kfence/core.c
> index 4d21ac44d5d35..33bb20d91bf6a 100644
> --- a/mm/kfence/core.c
> +++ b/mm/kfence/core.c
> @@ -733,6 +733,13 @@ void kfence_shutdown_cache(struct kmem_cache *s)
>
>  void *__kfence_alloc(struct kmem_cache *s, size_t size, gfp_t flags)
>  {
> +       /*
> +        * Perform size check before switching kfence_allocation_gate, so that
> +        * we don't disable KFENCE without making an allocation.
> +        */
> +       if (size > PAGE_SIZE)
> +               return NULL;
> +
>         /*
>          * allocation_gate only needs to become non-zero, so it doesn't make
>          * sense to continue writing to it and pay the associated contention
> @@ -757,9 +764,6 @@ void *__kfence_alloc(struct kmem_cache *s, size_t size, gfp_t flags)
>         if (!READ_ONCE(kfence_enabled))
>                 return NULL;
>
> -       if (size > PAGE_SIZE)
> -               return NULL;
> -
>         return kfence_guarded_alloc(s, size, flags);
>  }
>
> --
> 2.32.0.93.g670b81a890-goog
>