linux-kernel - Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YNyB/+fNK0u2bI6j@kunai>
Date:   Wed, 30 Jun 2021 16:38:55 +0200
From:   Wolfram Sang <wsa@...nel.org>
To:     Viresh Kumar <viresh.kumar@...aro.org>
Cc:     Arnd Bergmann <arnd@...db.de>, Jie Deng <jie.deng@...el.com>,
        Linux I2C <linux-i2c@...r.kernel.org>,
        virtualization@...ts.linux-foundation.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Jason Wang <jasowang@...hat.com>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        conghui.chen@...el.com, kblaiech@...lanox.com,
        jarkko.nikula@...ux.intel.com,
        Sergey Semin <Sergey.Semin@...kalelectronics.ru>,
        Mike Rapoport <rppt@...nel.org>, loic.poulain@...aro.org,
        Tali Perry <tali.perry1@...il.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        yu1.wang@...el.com, shuo.a.liu@...el.com,
        Stefan Hajnoczi <stefanha@...hat.com>,
        Paolo Bonzini <pbonzini@...hat.com>
Subject: Re: [PATCH v10] i2c: virtio: add a virtio i2c frontend driver

Hi Viresh,

> While we are at it, this has been replaced by a Rust counterpart [1]
> (as that makes it hypervisor agnostic, which is the goal of my work
> here) and I need someone with I2C knowledge to help review it. It
> should be okay even if you don't understand Rust a lot, just review
> this file[2] which is where most of i2c specific stuff lies.

From the high level review I can provide, it looks good to me. Block
transfers are missing, but I think you said that already. Mising Rust
experience, I might miss details, of course. But the general approach
seems fine to me. smbus_prepare() will get a bit more messy when you add
block transfers, but it still looks bearable, I think.

Happy hacking!

   Wolfram


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)