linux-kernel - Re: [PATCH] rcu: Remove unnecessary updates to ret in rcu_gp_fqs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20210630042314.GU4397@paulmck-ThinkPad-P17-Gen-1>
Date:   Tue, 29 Jun 2021 21:23:14 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     liu.song11@....com.cn
Cc:     fishland@...yun.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rcu: Remove unnecessary updates to ret in rcu_gp_fqs_loop

On Wed, Jun 30, 2021 at 11:22:53AM +0800, liu.song11@....com.cn wrote:
> > rcu: Remove useless "ret" update in rcu_gp_fqs_loop()
> >      
> >     Within rcu_gp_fqs_loop(), the "ret" local variable is set to the
> >     return value from swait_event_idle_timeout_exclusive(), but "ret" is
> >     unconditionally overwritten later in the code.  This commit therefore
> >     removes this useless assignment.
> 
> The revised commit log is exactly what I want to express, it is perfect.

Thank you for looking it over!

							Thanx, Paul