linux-kernel - Re: [PATCH] powercap: Replace symbolic permissions with octal permissions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 30 Jun 2021 11:00:12 -0700
From:   Joe Perches <joe@...ches.com>
To:     "Rafael J. Wysocki" <rafael@...nel.org>,
        Jinchao Wang <wjc@...rlc.com>
Cc:     "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux PM <linux-pm@...r.kernel.org>
Subject: Re: [PATCH] powercap: Replace symbolic permissions with octal
 permissions

On Wed, 2021-06-30 at 19:41 +0200, Rafael J. Wysocki wrote:
> On Thu, Jun 24, 2021 at 10:44 AM Jinchao Wang <wjc@...rlc.com> wrote:
> > 
> > Resolve following checkpatch issue,
> > Replace symbolic permissions with octal permissions
> 
> I don't see much value in this replacement and checkpatch complaining
> about the existing code base is not something to worry about in
> general.

https://lore.kernel.org/lkml/CA+55aFw5v23T-zvDZp-MmD_EYxF8WbafwwB59934FV7g21uMGQ@mail.gmail.com/

I do agree that in general checkpatch should not really be used as
the sole argument in favor of changing existing code.

So removing the "resolve following checkpatch issue" from the
commit message and replacing it with something like "to improve
readability" would be better.